Bug 111383 - DiagramModelingAssistantProvider contributes Note's too aggressively
Summary: DiagramModelingAssistantProvider contributes Note's too aggressively
Status: RESOLVED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-10-03 17:16 EDT by Min Idzelis CLA
Modified: 2010-07-19 12:17 EDT (History)
0 users

See Also:

Attachments
DiagramModelingAssistantProvider.patch (2.74 KB, patch)
2005-10-03 17:17 EDT, Min Idzelis CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Min Idzelis CLA 2005-10-03 17:16:07 EDT 
The DiagramModelingAssistantProvider returns the NoteAttachment relationship too
aggresively. It should check to see that the source edit part is an instance of
INoteable, and if so call it's canAttachNote() method. If it isn't a INoteable,
then it should return empty list. 

Will attach patch.
Comment 1 Min Idzelis CLA 2005-10-03 17:17:05 EDT 
Created attachment 27783 [details]
DiagramModelingAssistantProvider.patch
Comment 2 Cherie Revells CLA 2005-10-05 16:20:10 EDT 
Purpose: 
Bugzilla 111383 DiagramModelingAssistantProvider contributes Notes too 
aggressively 
- Mindaugas provided patch, " 
The DiagramModelingAssistantProvider returns the NoteAttachment relationship too
aggresively. It should check to see that the source edit part is an instance of
INoteable, and if so call it's canAttachNote() method. If it isn't a INoteable,
then it should return empty list.
" 
- Renamed INoteable to INotable and moved to a public package. 
- Added JUnit for this scenario: NoteTests.testConnectorHandleForNoteAttachment 

Activities: 
bugzilla 111383 gmf_head sshaw 051005 DiagramModelingAssistantProvider 
contributes Notes too aggressively 

Code Reviewed by: 
Steve 

How tested: 
Adhoc tests with connector handles to see if note attachment shows up. 

JUnit Tests:   

Launching org.eclipse.gmf.tests.runtime.diagram.ui 

OK, Runs:        58, Fails:        0, Errors:        0, 
org.eclipse.gmf.tests.runtime.diagram.ui, Time:        54.312 

Impact on QE: 
n/a 

Impact on Doc: 
n/a 

Impact on Build: 
n/a
Comment 3 Cherie Revells CLA 2005-10-05 16:20:48 EDT 
Resolved, see comments I just entered.
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:17:55 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
UI was the original product and component for this bug