Bug 111189 - xref view doesn't show declare warning matches on inner classes
Summary: xref view doesn't show declare warning matches on inner classes
Status: RESOLVED FIXED
Alias: None
Product: AJDT
Classification: Tools
Component: UI (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 1.2.1   Edit
Assignee: Helen Beeken CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-30 05:05 EDT by Helen Beeken CLA
Modified: 2005-10-13 04:01 EDT (History)
0 users

See Also:

Attachments
eclipse workspace (70.82 KB, image/jpeg)
2005-09-30 05:08 EDT, Helen Beeken CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Beeken CLA 2005-09-30 05:05:38 EDT 
This is a consequence of AspectJ bug 77269. Given the following program in
Test.java:


class Test {
	
	public void testMethod() {
		new Runnable() {
			public void run() {
			}
		};
		class C {
			public void m(){			
			}
		}
	}
	
}

aspect A {
	
	declare warning : execution(* m(..)) : "blah";
	
	declare warning : execution(* run(..)) : "blah blah";


}


The declare warning matches appear in the gutter markers and in the ajde
structure model. In the xref view, however, they only appear as nodes under the
aspect and not under the class.
Comment 1 Helen Beeken CLA 2005-09-30 05:08:17 EDT 
Created attachment 27718 [details]
eclipse workspace

Picture of the xref view, gutter markers and structure model view showing the
problem reported in this bug.
Comment 2 Helen Beeken CLA 2005-10-04 05:31:21 EDT 
The problem only occurs if you have "show xrefs for entire file" selected.
Otherwise it works as expected i.e. the xrefs for the inner classes are shown.
Comment 3 Helen Beeken CLA 2005-10-06 03:53:30 EDT 
The problem was in the recursion algorithm in
XReferenceContentProvider.addChildren(..) which was preventing the lower levels
of the tree being displayed.

The fix and tests have been integrated into both the AJDT 1.2 and 1.3 streams
(tests are in org.ajdt.ui.tests, XReferenceViewContentsTest.java).

Waiting on clean builds.
Comment 4 Helen Beeken CLA 2005-10-13 04:01:52 EDT 
The builds which contain this fix are:

AJDT 1.3: 20051011134207
AJDT 1.2: 20051007170626

Therefore, closing this bug as fixed.