Community
Participate
Working Groups
There are issues with our scroll buttons in compartments. I think these scrollbars are so ugly and hard to use. Why don't we use the scroll bars that GEF uses? To see the GEF scrollbars, create a circuit in the GEF logic diagram. Issue 1: There are no scroll bars. It is annoying to have to click on the little scroll button all the time. You cannot tell where you are scrolled in the compartment relative to the contents. We should have scroll bars. Issue 2: Vertical down scroll button covers the horizontal right scroll button. To reproduce: - Create a logic diagram. - Create a circuit. - Add a LED in the circuit. - Resize the circuit so that it is smaller than the LED horizontally and vertically. RESULT: The vertical down scroll button covers the horizontal right scroll button. Issue 3: Both vertical and horizontal scroll buttons seem stay even after the shape is resized. To reproduce: - Do steps for Issue 2. - Resize the circuit horizontally so it is big enough horizontally to fit its contents. RESULT: The horizontal scroll buttons still appear. They should go away like in the GEF logic diagram.
Issue 1: I think the current scroll can be more elegant and less intrusive in certain contexts (ListCompartments). I there's a way to bypass these and use the GEF / SWT scroll bars. Issue 2 / 3: Sounds like bugs with current implementation.
Changing component to "Runtime Diagram"
We need to look at: Issue 2: Vertical down scroll button covers the horizontal right scroll button. To reproduce: - Create a logic diagram. - Create a circuit. - Add a LED in the circuit. - Resize the circuit so that it is smaller than the LED horizontally and vertically. RESULT: The vertical down scroll button covers the horizontal right scroll button. Issue 3: Both vertical and horizontal scroll buttons seem stay even after the shape is resized. To reproduce: - Do steps for Issue 2. - Resize the circuit horizontally so it is big enough horizontally to fit its contents. RESULT: The horizontal scroll buttons still appear. They should go away like in the GEF logic diagram.
Created attachment 54685 [details] proposed patch (attempt 1) Here is an attempt to fix these issue: 3) currently we have both scroll bars appearing, although only one may be required. So I fixed this such that only scroll bars required to show will show and not both always. 2) I couldn't reproduce it - either I'm not following the steps correctly, or simply didn't notice this behavior or it's been fixed indirectly 1) I actually added the scroll thumbs, but set the alpha for the thumb figure to 0.5, so it looks nice. Perhaps, it's not a bad idea to have it.
Guys, regarding the scroll thumbs I'd like to add, could you please try this patch out when you get a free minute and provide me with some user feedback on the thumbs that I put for the scroll bars? Thanks in advance.
Committed the patch. The scroll buttons are still ugly in my opinion, but we have put in a request with the Media Design Team for some new ones.
[target cleanup] 2.0 M4 was the original target milestone for this bug
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug
