Bug 110848 - Paste puts new shapes right on top of old shapes
Summary: Paste puts new shapes right on top of old shapes
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows 2000
: P1 major
Target Milestone: ---   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2005-09-27 14:04 EDT by Cherie Revells CLA
Modified: 2005-11-17 17:17 EST (History)
0 users

See Also:

Attachments
patch (1.00 KB, patch)
2005-11-17 09:34 EST, Cherie Revells CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2005-09-27 14:04:04 EDT 
To reproduce:
1. Copy a shape.
2. Paste the shape.
RESULT:  The new shape appears right on top of the old shape.  It's not obvious 
that the paste worked.  The new shape should be offset a bit.  It used to work 
like this.
Comment 1 Steven R. Shaw CLA 2005-10-06 14:35:46 EDT 
Changing component to "Runtime Diagram"
Comment 2 Steven R. Shaw CLA 2005-11-15 14:05:38 EST 
Pushing the priority up since this can be very confusing.  It's difficult to 
know that the paste even occurred causing the user to do multiple pastes...

Additional note: if the original shapes aren't in the viewport, then it should 
paste to the center of the viewport.
Comment 3 Cherie Revells CLA 2005-11-17 09:34:00 EST 
Created attachment 30138 [details]
patch

Attached is the fix.  Two files.
Comment 4 Cherie Revells CLA 2005-11-17 17:17:49 EST 
Purpose: 
Bugzilla#110848 Paste puts new shapes right on top of old shapes 
- Regression caused be refactoring changes.  Simple fix to 
org.eclipse.gmf.runtime.diagram.ui.internal.commands.PasteCommand.  I also now 
reveal the editpart in DiagramGlobalActionHandler.

Activities: 
Bugzilla#110848 gmf_head cmahoney 051117 Paste puts new shapes right on top of 
old shapes 

Code Reviewed by:
Steve

How tested: 
Verified paste put new view slightly offset from copied view as it previously 
did and pasted shape gets revealed.

JUnit Tests:  
diagram.ui -- 71/71
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug