Community
Participate
Working Groups
3.1 Whenever I have an InvocationTargetException in the log view, I have to scroll down to see the really interesing part, which is the wrapped exception (i.e. the 'Caused by' part) An UI option should be provided to save people this useless scrolling (similarly to what JUnit view does for stack trace filtering)
updating title
Jacek, up your alley :)?
adding context
Created attachment 82000 [details] mylyn/context/zip
Created attachment 86269 [details] patch patch adds filtering to event details dialog. Have a look Chris.
Created attachment 86270 [details] mylyn/context/zip
Created attachment 86271 [details] screenshot enjoy :) btw, JUnit preferences is great idea, however I kept filter options inside Event Dialog, to avoid cluttering preferences e.g. in RCP using our wonderful log view.
taking a look at this now.... thanks Jacek!
Created attachment 86320 [details] org.eclipse.ui.views.log.patch I updated the patch to include better wording. The functionality is perfect. Before we put this in however, I think we should be able to configure the stack trace filters within the actual filters dialog. There should be a new Group (ie., Stack Trace) with what is currently contained within EventDetailsStackFilterDialog. This would be more consistent with how we currently do things within the log view. The ability to Configure Filters from there is a good idea. However, I think this should be done with a button, similar to how we do it with the Up/Down/Copy buttons. I think adding one with the filter icon should be good. Let me know if you have any other ideas :)
Created attachment 86321 [details] mylyn/context/zip
Created attachment 86365 [details] patch - moved filter options to filter dialog - created button instead of Link in Event Details dialog So now all filters are back in Filter Dialog. I only used composite instead of Group, because that looked better. For me yet another button in Event Details dialog doesn't look good, but see yourself. Link was more intuitive and subtle :) I'd remove that button.
Created attachment 86366 [details] mylyn/context/zip
Great work Jacek, I'm actually sitting next to Wassim and we're reviewing the patch. You're right, the button doesn't look right now, BUT, how about we change the order so there's a 2x2 box of buttons. In the first column, you have the Up/Down keys, in the next column, you have the Copy Details and Filter button. This should look better than what is available. What do you think? Oh also, can you ident the listviewer a bit so that it's easy to see that the checkbox affects the listviewer? Sort of how we ident right above it with the "Show events logged..." Good stuff Jacek, after this change I will commit if it looks good. This is a very neat feature!
Created attachment 86368 [details] patch Aaa, Wassim help! is he always like that? ;)
Created attachment 86369 [details] mylyn/context/zip
Created attachment 86371 [details] patch the same, but with ToolTip for Filter button
beautiful work Jacek. In the future, we can try to replicate more of the functionality of the JUnit stack trace filters. For now, this allows you to use stack trace filters in a minimally invasive and useful way :) Thanks!
