Bug 109973 - [quick fix] avoid proposals based on old markers
Summary: [quick fix] avoid proposals based on old markers
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P5 minor (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-20 05:15 EDT by Philipe Mulet CLA
Modified: 2022-11-02 17:24 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2005-09-20 05:15:51 EDT
Build id: M20050914-1235

When selecting in problem view quickfix for missing @Override annotation on some
method, it will not check for the existence of the annotation. Thus, when
autobuild is off, one may execute the same quickfix 10 times, and trigger 10
@Override annotation insertions.
Comment 1 Martin Aeschlimann CLA 2005-09-20 09:59:37 EDT
How did you invoke the quick fix? From the problems view?

When I try this in the editor, the first invocation of the quick fix solves the
problem (squiggles go away) and no second invocation of the quick fix is possible.
Comment 2 Deepak Azad CLA 2010-06-04 08:51:42 EDT
Works correctly with I20100603-1500. Second invocation of quick fix is not possible.
Comment 3 Markus Keller CLA 2010-06-04 09:17:55 EDT
Philippe said he invoked quick fix in the Problems view, and there, the bug is still reproducible. Same bug in the Java editor when you disable auto-build, save, close, and reopen the CU before invoking Quick Fix the second time.
Comment 4 Markus Keller CLA 2010-06-04 09:27:49 EDT
> Philippe said he invoked quick fix in the Problems view, and there, the bug
> is still reproducible.
That scenario doesn't produce multiple @Override annotations any more, but the quick fix is still offered (and shows an info dialog when executed).

Possible fixes:
a) remove the marker when applying the quick fix
b) add infrastructure to check whether original problem is still there, before applying the quick fix

We could consider (a), but I think (b) would be too much work for too little interesting outcome. The workaround is to keep auto-build enabled.

No plans to work on this for now.
Comment 5 Eclipse Genie CLA 2020-09-15 13:47:03 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 6 Eclipse Genie CLA 2022-11-02 17:24:24 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.