Bug 109333 - [DOM/AST] OR_OR and AND_AND expression are not converted to an infix expression using extended operands
Summary: [DOM/AST] OR_OR and AND_AND expression are not converted to an infix expressi...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M2   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-12 16:34 EDT by Olivier Thomann CLA
Modified: 2005-09-20 13:03 EDT (History)
0 users

See Also:

Attachments
Proposed fix (10.17 KB, patch)
2005-09-12 17:06 EDT, Olivier Thomann CLA 		no flags Details | Diff
Regression test (4.08 KB, patch)
2005-09-12 17:07 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2005-09-12 16:34:46 EDT 
The following code doesn't create an infix expression with extended operands. It
creates a tree of infix expressions.
The specs of the InfixExpression class clearly states that extended operands
must be used as much as possible.
The fix is trivial.
Comment 1 Olivier Thomann CLA 2005-09-12 17:06:16 EDT 
Created attachment 27054 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2005-09-12 17:07:15 EDT 
Created attachment 27055 [details]
Regression test

Needs to be applied on org.eclipse.jdt.core.tests.dom
Comment 3 Olivier Thomann CLA 2005-09-12 17:21:09 EDT 
Fixed and released in HEAD.
Added regression test in
org.eclipse.jdt.core.tests.dom.ASTConverterTestAST3_2.test616/617.
Comment 4 Maxime Daniel CLA 2005-09-20 12:31:42 EDT 
Verified for 3.2 M2 on build Build id: I20050920-0010.
Comment 5 Olivier Thomann CLA 2005-09-20 13:03:39 EDT 
Verified in I20050920-0010 for 3.2M2