Bug 109109 - Missing return keyword in BuildConsolePartition.equals(Object)
Summary: Missing return keyword in BuildConsolePartition.equals(Object)
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.1   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-09-08 19:33 EDT by Matthias Spycher CLA
Modified: 2009-01-09 16:58 EST (History)
2 users (show)

See Also:

Attachments
patch (695 bytes, patch)
2005-09-08 19:34 EDT, Matthias Spycher CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Spycher CLA 2005-09-08 19:33:30 EDT 
Body of if statement should contain: return fstream.equals(...);

public boolean equals(Object partition) {
  if (super.equals(partition)) {
    fStream.equals(((BuildConsolePartition) partition).getStream());
  }
  return false;
}

Stumbled on this while browsing the code.
Comment 1 Matthias Spycher CLA 2005-09-08 19:34:12 EDT 
Created attachment 26975 [details]
patch
Comment 2 Doug Schaefer CLA 2005-09-28 15:54:47 EDT 
Thanks, I've applied the patch to HEAD (3.1). I'm not sure what ill behavior
this caused, but it looks better.
Comment 3 Doug Schaefer CLA 2008-06-03 14:22:58 EDT 
assigning
Comment 4 Doug Schaefer CLA 2008-06-03 14:23:17 EDT 
done