Community
Participate
Working Groups
selection update on text viewer's dispose causes NPE and performance loss Now StructuredTextViewer sets empty selection on disposing (handleDispose() method). But it causes many visual cue updatation when it work with some editors. This means performance loss of close editor action. And during the visual cue updatation some NPE occurres in some editors' code because some objects in the editor are already disposed before the text viewer. How about disconnecting ViewerSelectionManager from StructuredTextViewer before setting empty selection?
<from David> Nitin, *not* doing this was special, final null check was causing memory leak on previous version, and fixed that, but causes this problem, and, I believe, eliminates the ability to use the "go to last edit postioin" after editor is closed (there's another bug on that). Can you please look at fixing all? :)
Not sure how to reproduce this one based on the given information but from the results it seems to me that if this was still happening it would not be a 5 year old back burner bug. Vote to resolve.
Ian, if we can't close an editor and use the toolbar to go back to the last editor position, opening the editor, it's still a problem.
(In reply to comment #3) > Ian, if we can't close an editor and use the toolbar to go back to the last > editor position, opening the editor, it's still a problem. Ahh, ok. Well it seems this functionality is intermittent. That is when I use Alt-LEFT it will always re-open a closed editor but only put the cursor in the correct location sometimes, other times the cursor will be placed at the start of the document.
