Bug 105941 - [osgi] Use separate encoding for console i/o
Summary: [osgi] Use separate encoding for console i/o
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.0   Edit
Hardware: Other other
: P3 enhancement (vote)
Target Milestone: 3.2 RC1   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2005-08-03 12:10 EDT by Brian Lillie CLA
Modified: 2006-08-23 15:20 EDT (History)
2 users (show)

See Also:


Attachments
Patch to support new property for console encoding. (937 bytes, patch)
2005-08-04 14:52 EDT, Daniel M. Schumacher CLA
no flags Details | Diff
patch (1.17 KB, patch)
2006-04-10 15:28 EDT, Thomas Watson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Lillie CLA 2005-08-03 12:10:33 EDT
Attempting to use the console while running the Eclipse OSGi framework on IBM 
zSeries (EBCDIC character base) runs into problems with encoding.

- in many cases, the file.encoding is set to 8859_1 to handle files that have 
been transferred as part of zip files and retain the ascii encoding

- the console i/o needs to run in the native platform encoding, and cannot use 
8859_1 and handle the i/o correctly.

Rather than using the file.encoding to set the encoding within the 
FrameworkConsole class, define a new property such as osgi.console.encoding 
that is used only for the console encoding.  This would then become the 
default encoding used.
Comment 1 Daniel M. Schumacher CLA 2005-08-04 14:52:19 EDT
Created attachment 25702 [details]
Patch to support new property for console encoding.

If property osgi.console.encoding present, use it, otherwise default to use
file.encoding property as before.
Comment 2 Thomas Watson CLA 2006-04-10 15:27:12 EDT
Simple fix to include into 3.2 RC1.  I will attach an updated patch.
Comment 3 Thomas Watson CLA 2006-04-10 15:28:27 EDT
Created attachment 38203 [details]
patch

updated patch to use FrameworkProperties instead of System
Comment 4 Thomas Watson CLA 2006-04-10 15:32:24 EDT
Jeff, please approve for RC1.  very simple fix, but adds a new config property :(
Comment 5 Jeff McAffer CLA 2006-04-11 10:04:45 EDT
+1 what's another property between friends...
Comment 6 Thomas Watson CLA 2006-04-11 11:09:06 EDT
patch has been released.

[contributed patch applied]
Comment 7 Thomas Watson CLA 2006-08-23 15:20:30 EDT
adding "contributed" keyword to patches contributed by the community.