Bug 105384 - Caret not revealed when typing in text example
Summary: Caret not revealed when typing in text example
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy GEF (MVC) (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-27 17:58 EDT by Randy Hudson CLA
Modified: 2016-12-14 11:19 EST (History)
1 user (show)

See Also:

Attachments
patch for the caret and scrolling problem (7.46 KB, patch)
2005-07-29 11:56 EDT, Takahiro Kato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Hudson CLA 2005-07-27 17:58:11 EDT 
Type a really large word with no spaces. The caret will go outside the viewer
and disappear. The caret gets placed during the updatemanager's validate step.
It's going to be tricky to actually scroll the viewport right after the layout
has occurred. I think it's not a problem though. It just adds more dirty regions
and should not cause more invalid figures to be added.
Comment 1 Takahiro Kato CLA 2005-07-29 11:56:10 EDT 
Created attachment 25467 [details]
patch for the caret and scrolling problem

see my comment.
Comment 2 Takahiro Kato CLA 2005-07-29 12:54:38 EDT 
Comment on attachment 25467 [details]
patch for the caret and scrolling problem

Hi, I have created a patch for the problem.  The viewport is updated by update
manager in the same way as it's done for the caret.

Also, it fixes the problem with scrolling using scrollbars or a mouse wheel.  I
have created an inner class in GraphicalTextViewer that listens to the
viewport's range models.
Comment 3 Pratik Shah CLA 2005-08-02 20:49:05 EDT 
Aah, now I see why the patch you attached to bug 105813 seemed to have a lot 
of code that wasn't required.  It included the fix for this bug as well.
Comment 4 Pratik Shah CLA 2005-08-03 17:31:44 EDT 
Takahirosan, for this bug fix, I suspect you can get away with updating the 
viewport's location during caret refresh, if needed (instead of having to do a 
separate viewport refresh).
Comment 5 Takahiro Kato CLA 2005-08-03 17:36:28 EDT 
Yes, you should be able to call queueViewportRefresh() before/after
queueCaretRefresh() call in the update listener.
Comment 6 Alexander Nyßen CLA 2013-10-17 09:44:39 EDT 
Unset target milestone as the specified one is already passed.