Community
Participate
Working Groups
This is a bug in the new dynamically option enablement call-back (Bug 95762) The code to call isOptionEnabled is commented out. This means that options are always enabled. isOptionVisible and isOptionUsedInCommandLine appear to be called as expected.
Created attachment 25313 [details] Suggested patch This patch simply uncomments the code. Note - it's likely I misunderstand the reason for this block being commented.
This somehow happened when merging in Symbian's patch for shared tool options into my previous patch to provide the callback. I think this was inadvertant. Highly recommend we fix this for 3.0, as otherwise the feature just doesn't work.
I don't know any reason why the option anablemet code was comented, so I agree with the proposed patch. I agree we should fix this for the 3.0.
I am going to go ahead and apply this so that it gets into today's build.
Lars and/or Bala, Please run any ToolChain option tests that you have after this patch is applied. The can't remember why I commented out that code. It could be that I commented it out while making the IOptionHolder changes and forgot to go back to it, or it could be that I anticipated a problem and forgot to go back to address it. The ToolChain options is one area that I coud have anticipated a problem, since those had just been added. Thanks, Leo
I ran all the core tests and this doesn't seem to mess anything up. Although, even without the change, there are a bunch of tests failing. I think it's just a matter of the benchmarks requiring an update. Will follow up on that on cdt-test-dev
Chris, Those tests weren't failing the last time I ran them. I would guess that they have to do with "content-type" changes (e.g. uppercase C and S were added to the C++ and ASM content types). That would change the source.mk file and cause the benchmarks to need to be updated. Thanks, Leo
Applied to HEAD
