Bug 104849 - JSP Toggle/Add comment should use JSP comment if selection contains JSP regions
Summary: JSP Toggle/Add comment should use JSP comment if selection contains JSP regions
Status: CLOSED DUPLICATE of bug 86520
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: jst.jsp (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: jst.jsp CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-22 13:46 EDT by David Williams CLA
Modified: 2006-11-28 15:39 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2005-07-22 13:46:00 EDT
In code such as following: 
Path info: <% out.print(util.HTMLFilter.filter(request.getPathInfo())); %>
<br>
Query string: <% out.print(util.HTMLFilter.filter(request.getQueryString())); %>

if the selection contains the JSP scriptlets, then the comments added should be
JSP Comments. 
If the selection contains only HTML regions (or HTML text) then the comments should 
be HTML comments (there might be some use case here to have both choices in this 
latter case, but in the first case, I do not think anyone would ever want to 
surround a JSP region with HTLM comments since they should have little effect,
the JSP region would still be a JSP region (though results might not be
"displayed" to end user at their browser, it results of the evalutated code
could be in the browsers 'source' for the page). 

FYI ... I know we are not supposed to group bugs ... but there's a number of
inconsistent, or not helpful behaviors here. Such as if cursor is at 'request'
in above example, I suspect the users intent is to surround whole JSP scriptlet
with a comment ... or ... probably we should investigate using Java comments if
inside a Java region.
Comment 1 Amy Wu CLA 2005-07-22 13:51:53 EDT
looks like dup of bug 86520
Comment 2 David Williams CLA 2005-07-22 14:05:18 EDT

*** This bug has been marked as a duplicate of 86520 ***
Comment 3 David Williams CLA 2005-07-28 11:10:19 EDT
verifying as correctly categorized
Comment 4 John Lanuti CLA 2006-11-28 15:39:01 EST
This is part of a mass update to close out all stale WTP defects already verified by the reporter but awaiting closure by the assignee.  If you feel this defect was closed inappropriately, please reopen.

Thanks, John Lanuti