Bug 104765 - Tab width error in Java Conventions [built-in]
Summary: Tab width error in Java Conventions [built-in]
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.2 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-22 03:07 EDT by Linus Tolke CLA
Modified: 2005-08-09 06:39 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Linus Tolke CLA 2005-07-22 03:07:22 EDT 
When I set up my workspace I choose the "Java Conventions [built-in]" profile in 
Window => Preferences => Java => Code Style => Formatter.

When I examine the result (using Show => Indentation) I notice that "Tab size"
is set to 4.

Testing this, I notice that code containing tabs according to the Java Code
Conventions is not displayed correctly (tabs are shown as corresponding to 4
spaces instead of 8). Changing "Tab size" (creating a new profile) and the code
displays correctly.
Comment 1 Tom Hofmann CLA 2005-07-22 04:05:27 EDT 
Indeed, DefaultCodeFormatterOptions.setJavaConventionsSettings sets a tab width
of 4, while the java conventions specify one of 8.

Moving to core.
Comment 2 Olivier Thomann CLA 2005-07-23 14:40:51 EDT 
This was due to the fact that this could not be changed as long as the Java
conventions was the default. Now that we have a new default profile, we can
change this.
Philippe, do you want it for 3.1.1 or I do it only in 3.2?
Comment 3 Olivier Thomann CLA 2005-07-27 09:11:02 EDT 
Will be fixed in HEAD only for now.
Comment 4 Olivier Thomann CLA 2005-07-27 09:25:42 EDT 
Fixed and released in HEAD.
Regression tests have been updated.
Comment 5 Jerome Lanneluc CLA 2005-08-09 06:39:26 EDT 
Verified with I20050808-2000