Bug 104704 - [compiler] caching in the constant pool could be improved
Summary: [compiler] caching in the constant pool could be improved
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-21 14:34 EDT by Olivier Thomann CLA
Modified: 2005-08-09 06:55 EDT (History)
0 users

See Also:

Attachments
Proposed fix (45.06 KB, patch)
2005-07-21 16:40 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (45.73 KB, patch)
2005-07-25 10:31 EDT, Olivier Thomann CLA 		no flags Details | Diff
Regression tests updated (92.27 KB, patch)
2005-07-25 10:31 EDT, Olivier Thomann CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2005-07-21 14:34:18 EDT 
Right now we do two accesses in the constant pool for each constant we want to add.
One to find out if it exists and one to add it if it doesn't. One access could
be enough. If it doesn't exist, we can add it immediately.
Comment 1 Olivier Thomann CLA 2005-07-21 16:40:39 EDT 
Created attachment 25156 [details]
Proposed fix

Note that you also need the patch for bug 104664 if you want to test using
-repeat on the batch compiler's command line.
Comment 2 Olivier Thomann CLA 2005-07-25 10:30:49 EDT 
Fix and released in HEAD.
Comment 3 Olivier Thomann CLA 2005-07-25 10:31:12 EDT 
Created attachment 25240 [details]
Proposed fix
Comment 4 Olivier Thomann CLA 2005-07-25 10:31:28 EDT 
Created attachment 25241 [details]
Regression tests updated
Comment 5 Olivier Thomann CLA 2005-07-25 10:31:51 EDT 
Remember to update ConformTests as well.
Comment 6 Jerome Lanneluc CLA 2005-08-09 06:55:32 EDT 
Verified with I20050808-2000