Bug 103761 - Move LaunchWSEAction from jst.ws into wst.ws
Summary: Move LaunchWSEAction from jst.ws into wst.ws
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 0.7   Edit
Hardware: PC Windows XP
: P2 major (vote)
Target Milestone: 3.0   Edit
Assignee: Gilbert Andrews CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2005-07-13 22:37 EDT by Dave Carlson CLA
Modified: 2008-05-16 14:48 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Carlson CLA 2005-07-13 22:37:11 EDT
It is currently not possible to launch the Web Services Explorer when 
installing only the WST distribution.  Investigation shows that the Run 
menu/toolbar command is misplaced in jst.ws and should be moved to wst.ws

This should be a very easy change.

This action command had no dependencies on jst and should be easily moved to 
wst.ws.explorer plugin.

Move this class to wst.ws.explorer plugin:
org.eclipse.jst.ws.internal.consumption.ui.action.LaunchWSEAction

And move the corresponding action declaration in the plugin.xml

Also another similar error in misplaced category definition in the 
wst.ws.explorer plugin.xml:

menubarPath="org.eclipse.jst.ws.atk.ui.webservice.category.popupMenu/popupActio
ns"

logs an error when JST in not installed.  Move this menubarPath definition 
from jst.ws.ui into wst.ws.explorer
Comment 1 David Williams CLA 2005-07-13 23:18:39 EDT
Thanks Dave, feel free to attach patches ... they really do make things easier
for us. 
Comment 2 Dave Carlson CLA 2005-07-13 23:41:13 EDT
I wasn't sure how much patches help with changes like this.  I'll create a 
fresh workspace from HEAD tomorrow and work on a patch for this one.
Comment 3 Chris Brealey CLA 2005-07-14 09:11:54 EDT
Dave, patches are like gold, especially at times like this when the core team 
is so very occupied with fixing the last of the critical bugs for WTP 0.7. 
Thanks very much for any help you can lend! Cheers - CB.
Comment 4 Chris Brealey CLA 2005-07-14 13:56:31 EDT
Tentatively tagetting to M6.
Comment 5 Dave Carlson CLA 2005-07-14 14:11:58 EDT
Chris,

I've made these changes and am starting to test, but one quick question for 
you:

A menubar extension for IResource is defined (but not used) in 
org.eclipse.jst.ws.ui
   org.eclipse.jst.ws.atk.ui.webservice.category.popupMenu/popupActions

It is then used in org.eclipse.wst.ws.explorer and 
org.eclipse.jst.ws.consumption.ui but I have not yet done an exhaustive search 
so may be used elsewhere.  This creates the "Web Services" popup submenu in 
the Navigator.

When installing only WST the menu path is undefined.  Where should we move 
this definition?  Maybe move to org.eclipse.wst.ws.ui?  If you agree, I'll do 
a complete search for other usage and add any missing dependencies on the 
wst.ws.ui plugin.

Thanks!
Comment 6 Chris Brealey CLA 2005-07-14 15:04:05 EDT
Dave,
moving the definition of the the menu bar path [1] from org.eclipse.jst.ws.ui 
to org.eclipse.wst.ws.ui is a good idea, since the latter plugin acts as the 
GUI foundation for the Web service tools at large. The menu id should also be 
simplified to, say, "org.eclipse.wst.ws.ui.menu".

FYI, the menu bar path is currently used by these plugins. The first already 
depends on org.eclipse.wst.ws.ui. The latter two don't, and would need to.
1. org.eclipse.jst.ws.consumption.ui
2. org.eclipse.jst.ws.creation.ui
3. org.eclipse.wst.ws.explorer

Also, sorry to bear bad news, but I am also deferring this to WTP 1.0. As much 
as I'd like to include this in WTP 0.7, the bar for committing changes to the 
WTP 0.7 codebase is getting really high on the status calls, and only truely 
critical bugs are getting approved for 0.7. Let me know if this is serious 
cause for concern.

Thanks again for your help! I've got lots more Web service bugs in our backlog 
if you're interested :)
Comment 7 Dave Carlson CLA 2005-07-14 16:11:24 EDT
Thanks, I'll get these patches done and to you, probably tomorrow.  I thought 
the 0.7 threshhold might be getting too high for this bug fix.

I am creating a complete package of Eclipse + subset of WST for use by XML 
designers (not programmers).  I will base this on 0.7 and promote to several 
standards groups, including OASIS and OAGi.  I'll need to use my patched 
version of wst.ws.explorer and wst.ws.ui for this distribution.  After the 
patch is committed, I can use a post-0.7 I-build of these two plugins.

I'll review other web services bugzilla entries and see if I can help out.
Comment 8 Chris Brealey CLA 2005-07-19 11:58:12 EDT
Assigned to me.
Comment 9 Chris Brealey CLA 2005-11-17 22:48:30 EST
Hi Dave, did you end up putting together any patches for this bug?
Comment 10 Chris Brealey CLA 2005-11-29 12:14:35 EST
Simple as this fix probably is, we're in the last couple weeks of shutting down WTP 1.0 and need to minimize changes. Deferring.
Comment 11 David Williams CLA 2007-09-06 04:24:37 EDT
I'm going to mark this as 3.0, but with help wanted. If it hasn't been fixed already, perhaps it is one that someone .... hummm, Dave? .... would be interested/able to supply a fix for? 

Or, maybe it's been fixed already? In 3.0? 



Comment 12 Gilbert Andrews CLA 2007-09-27 10:50:58 EDT
This has been fixed .3.0 so I am closing the defect
Comment 13 Kathy Chan CLA 2008-02-28 14:10:03 EST
Please verify the defect you originated with a recent WTP driver which could be found in:

http://download.eclipse.org/webtools/downloads/

If defects in resolved state is not verified within a couple of weeks, the development team might verify and close the defect on the originator's behalf.  Thank you for your attention!

Comment 14 Gilbert Andrews CLA 2008-05-16 14:48:11 EDT
This has been moved so I am officially closing this defect.