Bug 102459 - provide more detail in -showWeaveInfo messages
Summary: provide more detail in -showWeaveInfo messages
Status: RESOLVED FIXED
Alias: None
Product: AspectJ
Classification: Tools
Component: Compiler (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 1.5.0 M4   Edit
Assignee: Andrew Clement CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-01 06:48 EDT by Helen Beeken CLA
Modified: 2005-09-01 14:33 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helen Beeken CLA 2005-07-01 06:48:04 EDT
When advice is executed, the object you have to work with is the joinpoint. This
can then be queried to get various information out of it. It would be nice, if
as part of the weaving you could get hold of the same information. 

This is particularly useful in the case of writing a coverage tool. In order to
measure where you've been, you have to know all the places you could possibly
go. The introduction of the -showWeaveInfo option means that we can record these
places, however, this would be greatly enhanced by providing similar information
as to that which is collected as the program is running.

The information which would be good is the same as that obtained from

JoinPoint.StaticPart.getSignature().toLongString().
Comment 1 Andrew Clement CLA 2005-07-07 04:27:09 EDT
try and look at this for 1.5.0
Comment 2 Adrian Colyer CLA 2005-09-01 14:33:28 EDT
weave info messages for advice execution now have the form:

Join point 'method-execution(void Simple.method())' in Type 'Simple' (Simple.java:17) advised by 
afterThrowing advice from aspect 'AspectAdvice' (AspectAdvice.aj:20)

etc.

The new part is the prefix containing the join point information. I didn't change the tail end of the 
message because it would have upset too many test cases.

I actually prefer this new message since it makes the primary abstraction one of join points being 
advised, and not source locations.