Bug 101426 - [search] Search doesn't work with imported plugin
Summary: [search] Search doesn't work with imported plugin
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 101459 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-06-23 07:40 EDT by David Audel CLA
Modified: 2005-06-24 07:58 EDT (History)
3 users (show)

See Also:

Attachments
Patch to fix this issue (1.18 KB, patch)
2005-06-23 10:02 EDT, Frederic Fusier CLA 		no flags Details | Diff
Test case added to JavaSearchMultipleProjectsTests (2.22 KB, patch)
2005-06-23 11:08 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2005-06-23 07:40:31 EDT 
build I20050623-0010

1) import org.eclipse.pde.core plugin as souce (Import>External Plug-ins and
Fragments>)
2) open search dialog
3) search type declaration of IModel inside worspace
org.eclipse.pde.core.IModel is not found

This type cannot be seen inside Open Type window as well.
Comment 1 Philipe Mulet CLA 2005-06-23 07:44:02 EDT 
I imported all src plugins, and it works fine for me.
Comment 2 Philipe Mulet CLA 2005-06-23 07:55:21 EDT 
Searching references to IModel in workspace yields nothing either. Though
removing the file causes compile errors.
Comment 3 Frederic Fusier CLA 2005-06-23 07:57:18 EDT 
Reproduced but it works fine with RC3.
I'm investigating...
Comment 4 Philipe Mulet CLA 2005-06-23 09:00:25 EDT 
I confirm comment 1, for me, in full source workspace, open type and search for
IModel type decl (workspace) performs ok. Only refs to IModel to fail.
Comment 5 Philipe Mulet CLA 2005-06-23 09:22:03 EDT 
Reference search looks a different problem, as addressing the scope issue has no
influence on it.
Comment 6 Frederic Fusier CLA 2005-06-23 10:02:42 EDT 
Created attachment 23845 [details]
Patch to fix this issue

Test if scopePath already ends with a '/'. In this case test path char one
position before...

This patch fixes the problem and pass all JDT/Core and JDT/UI tests
Comment 7 Frederic Fusier CLA 2005-06-23 10:03:48 EDT 
Note that this patch also revert change in indexOf(String,String) method as it
is no longer necessary => minimize possible side effects...
Comment 8 Frederic Fusier CLA 2005-06-23 11:08:34 EDT 
Created attachment 23856 [details]
Test case added to JavaSearchMultipleProjectsTests
Comment 9 Jerome Lanneluc CLA 2005-06-23 11:11:38 EDT 
*** Bug 101459 has been marked as a duplicate of this bug. ***
Comment 10 Philipe Mulet CLA 2005-06-23 11:17:59 EDT 
Dirk / Dani : pls cast your votes.
Comment 11 Dirk Baeumer CLA 2005-06-23 12:17:08 EDT 
+1 for RC4.
Comment 12 Frederic Fusier CLA 2005-06-23 12:17:48 EDT 
Patches attached at comment 6 and comment 8 released in HEAD.
Comment 13 Dani Megert CLA 2005-06-23 12:59:38 EDT 
+1 for 3.1 RC4
Comment 14 Maxime Daniel CLA 2005-06-24 07:55:08 EDT 
Verified for Build id: I20050624-0010.
Comment 15 Olivier Thomann CLA 2005-06-24 07:58:42 EDT 
Verified.