Bug 101120 - Cannot generate an executable of the batch compiler using gcj 3.4.4
Summary: Cannot generate an executable of the batch compiler using gcj 3.4.4
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-21 15:37 EDT by Olivier Thomann CLA
Modified: 2005-06-24 07:45 EDT (History)
3 users (show)

See Also:

Attachments
Patch that is fixing both issues (9.22 KB, patch)
2005-06-21 15:54 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2005-06-21 15:37:20 EDT 
In latest, the class Messages.java collides with the properties file
messages.properties when generating the executable using gcj on Windows XP.

A second problem is related to
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=21540. This bug prevents the class
CompilerOptions from being properly compiled by gcj.
Comment 1 Philipe Mulet CLA 2005-06-21 15:42:43 EDT 
I would vote to fix the collision by moving messages.properties file to its
parent folder (/org.eclipse.jdt.core/compiler/org/eclipse/jdt/internal/compiler).

As Olivier figured, collision got introduced when switching to new NLS format.

This prevents building ecj on Win32 machines (which aren't case sensitive).
Fix is trivial, candidating for RC4.

We need to keep translators in the loop.

Dirk - would you vote for it ?
Comment 2 Philipe Mulet CLA 2005-06-21 15:49:05 EDT 
Dani - would you vote for it ?
Comment 3 Dani Megert CLA 2005-06-21 15:53:27 EDT 
+1 for 3.1 RC4.
Comment 4 Olivier Thomann CLA 2005-06-21 15:54:10 EDT 
Created attachment 23662 [details]
Patch that is fixing both issues

In fact I got some help from Tom Tromey from Redhat about the collision
problem.
Comment 5 Olivier Thomann CLA 2005-06-21 16:33:35 EDT 
With the patch, I can generate the executable. I'll try to modify the script to
use the .class file version of the CompilerOptions class. This would reduce the
patch.
Comment 6 Dirk Baeumer CLA 2005-06-21 17:15:44 EDT 
+1 for RC4.
Comment 7 Olivier Thomann CLA 2005-06-22 11:46:14 EDT 
Fixed and released in HEAD.
Comment 8 Olivier Thomann CLA 2005-06-22 11:47:14 EDT 
messages.properties has been moved in its parent.
And temporary constant fields have been added in CompilerOptions. These will be
removed for 3.1.1.
Comment 9 Maxime Daniel CLA 2005-06-24 06:38:37 EDT 
Verified for Build id: I20050624-0010.
(Checked that source changes were present and that the file move took proper
effect in batch compiler reporting. Did nothing with gcj itself.)
Comment 10 Olivier Thomann CLA 2005-06-24 07:45:01 EDT 
Verified.