Community
Participate
Working Groups
Version: 3.1.0 Build id: I20050617-1618 Multi line log messages are being parsed but only the first line is being put into the LogEntry record. When you open a log entry in the log viewer you should be able to see the entire message. The entry i am trying to read looks like this: !ENTRY org.tigris.jira.core 1 -1 2005-06-19 12:01:30.15 !MESSAGE URL: http://jira.atlassian.com/secure/IssueNavigator.jspa?view=rss&decorator=none&reset=true&tempMax=100&pid=10240&createdPrevious=604800000&sorter/field=created&sorter/order=DESC Processed: 257 kb at 193.35938 kb/s in 1.329 second(s) Compression ratio of 83.34071 percent (42 kb read)
I am seeing the same problem in Eclipse 3.2, however the problem only occurs if the multi-line log entry is the last entry in the log file. Earlier entries in the file are read fine. Looking at LogReader.java it is clear why this is the case. When the state is changed away from TEXT_STATE the writerState is checked, with code such as: if (writerState == MESSAGE_STATE && current != null){ String message = current.getMessage() + swriter.toString(); message = message.trim(); current.setMessage(message); } being invoked to save any further lines of text that have been read, prior to calling: writer.close(); However, if the end of file is reached the state is never changed away from TEXT_STATE, and it is down to the finally block to close the writer - which it does. However the finally block doesn't save the text contained in the writer, it just throws it away. I should be able to grab a current copy of the code and produce a patch if that'd help get this issue resolved.
Not sure we could turn down an offer for help ;-) Attaching a patch would help get the issue resolved faster.
*** Bug 139729 has been marked as a duplicate of this bug. ***
tagging bugday
Created attachment 82401 [details] mylyn/context/zip
Created attachment 84115 [details] patch The only problem I found with multiline messages was that only the last message in log file didn't have complete message. Also regarding the duplicate bug - it refered to eating empty lines in messages, which is also fixed in attached patch. Note, it may conflict with bug 207344
Created attachment 84116 [details] mylyn/context/zip
Created attachment 84117 [details] logfile logfile used to test this bug.
Chris, after you get over your jet lag can you review this patch? If you are too busy, let me know.
Cool stuff. It worked in my tests. Released to HEAD. Thanks Jacek :)
By the way, I can't believe how long this one was open for :)
verified in I20071211-0010. Nice job fixing this bug Jacek. I remember looking at this one in the past thinking it should not be too hard, but then finding out it required a lot of investigation to get it right. Good job!
*** Bug 219066 has been marked as a duplicate of this bug. ***
*** Bug 236519 has been marked as a duplicate of this bug. ***
