Bug 100062 - [formatting] Code formatter is broken on test case from bug 99999
Summary: [formatting] Code formatter is broken on test case from bug 99999
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1 RC3   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-14 15:57 EDT by Olivier Thomann CLA
Modified: 2005-06-16 14:55 EDT (History)
1 user (show)

See Also:

Attachments
Corresponding regression test (3.18 KB, patch)
2005-06-14 16:34 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (1.27 KB, patch)
2005-06-14 16:35 EDT, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2005-06-14 15:57:39 EDT 
Try to format the test case from bug 99999.
It doesn't work.
Comment 1 Olivier Thomann CLA 2005-06-14 16:34:53 EDT 
Created attachment 23102 [details]
Corresponding regression test
Comment 2 Olivier Thomann CLA 2005-06-14 16:35:21 EDT 
Created attachment 23103 [details]
Proposed fix

It needs the fix for bug 99999.
Comment 3 Philipe Mulet CLA 2005-06-15 09:05:21 EDT 
+1 for RC3

Dani - would you vote for this one ?
Comment 4 Dani Megert CLA 2005-06-15 09:58:38 EDT 
How big is the risk to break other scenarios?
Comment 5 Olivier Thomann CLA 2005-06-15 10:06:06 EDT 
very low.
All our formatter tests passed.
Comment 6 Olivier Thomann CLA 2005-06-15 10:30:36 EDT 
The bug is in decoding this:

[1]

in the code formatter. We wrongly consider this as dimensions. This leads the
code formatter to format that part at the wrong moment and then it cannot find
expected tokens afterwards. This is why it fails.
Comment 7 Dani Megert CLA 2005-06-15 10:44:14 EDT 
+1 for 3.1 RC3.
Comment 8 Olivier Thomann CLA 2005-06-15 10:54:32 EDT 
Fixed and released in HEAD.
Regression test added in
org.eclipse.jdt.core.tests.formatter.FormatterRegressionTests.test583
Comment 9 Olivier Thomann CLA 2005-06-16 14:55:33 EDT 
Verified using N20050616-0010 + JDT/Core HEAD