Bug 99620

Summary: [compiler] The batch compiler should not print to the console when taking another output stream in input
Product: [Eclipse Project] JDT Reporter: Maxime Daniel <maxime_daniel>
Component: CoreAssignee: Maxime Daniel <maxime_daniel>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3    
Version: 3.1   
Target Milestone: 3.2 M5   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
Suggested change plus tests
none
Improved patch plus tests none

Description Maxime Daniel CLA 2005-06-13 08:49:12 EDT 
This is a follow up on https://bugs.eclipse.org/bugs/show_bug.cgi?id=98489,
which only bypassed the impacted test cases. Please see details there.
Not urgent.
Comment 1 Maxime Daniel CLA 2006-01-19 04:49:32 EST 
Created attachment 33254 [details]
Suggested change plus tests

Olivier, pls tell me what you think.
Comment 2 Olivier Thomann CLA 2006-01-19 11:32:38 EST 
Patch looks good.
We migth want to factorize the code for Compiler constructors.
Make out field protected and update the call in org.eclipse.jdt.core.dom.CompilationUnitResolver line 171.

Also we should consider making the same support for err.
Comment 3 Maxime Daniel CLA 2006-01-23 07:56:14 EST 
Created attachment 33456 [details]
Improved patch plus tests
Comment 4 Maxime Daniel CLA 2006-01-24 04:17:38 EST 
Test case: launch BatchCompilerTest and watch the console.
Comment 5 Jerome Lanneluc CLA 2006-02-14 08:43:26 EST 
Verified for 3.2 M5 using build I20060214-0010