Bug 97405

Summary: [options] Improve uselessTypeCheck warning name and scope
Product: [Eclipse Project] JDT Reporter: Maxime Daniel <maxime_daniel>
Component: CoreAssignee: Maxime Daniel <maxime_daniel>
Status: VERIFIED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: eric_jodet, philippe_mulet
Version: 3.1   
Target Milestone: 3.4 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Maxime Daniel CLA 2005-05-31 05:21:10 EDT
Two suggestions here:
- unnecessaryTypeCheck, as suggested by the warning name explanation itself,
would probably be a better name that uselessTypeCheck; in terms of conveyed
semantics on  the one hand; for the sake of homogeneity on the other hand (e.g.
with unnecessaryElse in the warning names, and with the UI, which says
unnecessare cast of instanceof);
- this applies to both casts and instanceof operations; I would contend that in
the context of a progressive adoption of parametrized types, unnecessary casts
will be numerous, and that it might be better to be able to activate the
matching warning independently from the checking of instanceof; this said, a new
unnecessaryCast category would be welcome, that would probably more intuitively
relate to cast operations than TypeCheck in the user's mind.
Comment 1 Maxime Daniel CLA 2006-11-27 07:15:56 EST
Philippe, what do you think for this one?
Comment 2 Maxime Daniel CLA 2007-09-07 05:50:53 EDT
Will close as WONTFIX except if Philippe tells otherwise.
Comment 3 Maxime Daniel CLA 2008-01-11 06:59:36 EST
Closing as WONTFIX.
Comment 4 Eric Jodet CLA 2008-02-04 09:30:14 EST
Verified for 3.4M5 using build I20080204-0010