Summary: | [prefs] JavaCore should not give access to default preferences | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||
Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | critical | ||||||
Priority: | P3 | CC: | jeem, philippe_mulet | ||||
Version: | 3.1 | ||||||
Target Milestone: | 3.1 M7 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Frederic Fusier
2005-04-15 04:14:27 EDT
We should remove offending methods from API. Note that these methods are not used and are not documented as part of the API, simply got added as public methods on an API class. Frederic : pls attach suggested patch for PMC consideration Basically, all internal methods tagged @since 3.1 should go away. Is this the full list of JavaCore methods and fields to be deleted from the API? public static final IEclipsePreferences[] preferencesLookup; public static IEclipsePreferences getDefaultPreferences(); public static IEclipsePreferences getInstancePreferences() { Please remove them from the API at the earliest possible opportunity. (According to my full source ws, there are no reference to any of these outside JDT Core.) Created attachment 19945 [details]
Patch to remove these publci methods/fields
Jeem, I confirm that this is the full list of removed public method and fields
(see patch for more details on implementation)
Frederic, Patch looks good. You can release anytime. Thanks jeem. Released in HEAD. Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD. |