Bug 90446

Summary: Update CreateTypeMemberOperation for changes in Indents
Product: [Eclipse Project] JDT Reporter: Martin Aeschlimann <martinae>
Component: CoreAssignee: Jerome Lanneluc <jerome_lanneluc>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: frederic_fusier, jerome_lanneluc
Version: 3.1   
Target Milestone: 3.1 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch none

Description Martin Aeschlimann CLA 2005-04-06 09:35:20 EDT 
20050406

I updated Indents to support mixed tab/space indents. Two methods used by
CreateTypeMemberOperation are now deprecated. The following patch brings
CreateTypeMemberOperation up to date.
Comment 1 Martin Aeschlimann CLA 2005-04-06 09:36:43 EDT 
Created attachment 19593 [details]
patch
Comment 2 Jerome Lanneluc CLA 2005-04-06 11:39:08 EDT 
Applying the path, several Java model tests are failing. Can you please 
investigate ?
Comment 3 Martin Aeschlimann CLA 2005-04-06 12:30:11 EDT 
In fact several tests in TypeHierarchyNotificationTest, RenameTests,
SortCompilationUnitElementsTests and CopyMoveElementsTests are failing. But it
seems that my changes have surfaced a bug at a different place:
An assertion is thrown as the option
DefaultCodeFormatterConstants.FORMATTER_TAB_CHAR was not found in the options
returned by JavaCore.getOptions().
When setting a breakpoint in JavaCore.getOptions ASTRewriteFormatter, line 134
you can see that only 5 options are returned

Maybe it would better to not have an assert there, but at least this helped
finding this bug. Let me know if I should remove it for now and tolerate the
missing option.

BTW: Jerome, not related to the bug, but note that CreateElementInCUOperation
line 95 would better not pass null as options but take the options from the
current IJavaProject.
Comment 4 Jerome Lanneluc CLA 2005-04-06 13:31:28 EDT 
Yes please remove your changes so that we don't break the nightly build.
Comment 5 Martin Aeschlimann CLA 2005-04-07 04:40:46 EDT 
filed bug 90580 for the missing options from JavaCore.getOptions
Comment 6 Jerome Lanneluc CLA 2005-04-07 06:45:53 EDT 
Applied patch.
Comment 7 Frederic Fusier CLA 2005-05-11 09:58:13 EDT 
Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD.