Bug 90295

Summary: ASTRewriteAnalyzer#doTextCopy(..) adds edit twice to group
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: CoreAssignee: Martin Aeschlimann <martinae>
Status: VERIFIED FIXED QA Contact:
Severity: minor    
Priority: P3    
Version: 3.1   
Target Milestone: 3.1 M7   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Markus Keller CLA 2005-04-05 10:09:26 EDT 
I20050401-1645

ASTRewriteAnalyzer#doTextCopy(..) contains code:
		if (editGroup != null) {
			addEditGroup(editGroup, targetEdit);
			addEditGroup(editGroup, targetEdit);
		}

I'd say it's sufficient to add the edit just once to the group. I found this
while debugging something else. I guess the two calls are just redundant, since
it doesn't cause any visible harm and things still work when I delete the second
call.
Comment 1 Markus Keller CLA 2005-04-06 10:59:15 EDT 
Bug 89524 revealed that the first call should be:

			addEditGroup(editGroup, sourceEdit);
Comment 2 Martin Aeschlimann CLA 2005-04-13 13:05:21 EDT 
fixed in 20050412
Comment 3 Martin Aeschlimann CLA 2005-04-13 13:06:33 EDT 
really fixed (wrong bugzilla radio button selected..)
Comment 4 Martin Aeschlimann CLA 2005-05-11 12:22:36 EDT 
verified in 20050509-2010