Bug 88719

Summary: UserLibrary.serialize /createFromString need support for access restriction / attributes
Product: [Eclipse Project] JDT Reporter: Martin Aeschlimann <martinae>
Component: CoreAssignee: Frederic Fusier <frederic_fusier>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: jreed, mike808, robert.jakubowski, rodge
Version: 3.1   
Target Milestone: 3.1 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch to implement this functionality none

Description Martin Aeschlimann CLA 2005-03-22 05:05:27 EST
20050322

UserLibrary.serialize/createFromString need to be updated to also save/load the
new classpath attributes and access restrictions
Comment 1 Martin Aeschlimann CLA 2005-04-04 10:25:37 EDT
*** Bug 90136 has been marked as a duplicate of this bug. ***
Comment 2 Martin Aeschlimann CLA 2005-05-11 04:25:32 EDT
*** Bug 94520 has been marked as a duplicate of this bug. ***
Comment 3 Martin Aeschlimann CLA 2005-05-11 04:28:13 EDT
Note that this is a major bug as users are loosing the Javadoc locations stored
for entries in user libraries
Comment 4 Frederic Fusier CLA 2005-05-17 04:33:10 EDT
Created attachment 21248 [details]
Patch to implement this functionality

Martin, let me know if this patch is ok for you.
I've tested it manually and that's sounds good, but I would prefer to have your
feedback about it.
Thanks
Comment 5 Frederic Fusier CLA 2005-05-17 08:57:01 EDT
Fixed and released in HEAD.

Extra attribute and access rules are now supported while reading/writing user
librairies. Fix passes both all JDT/Core and JDT/UI tests.

[jdt-core internal]
See patch for changes.

To verify it works:
1) create a User Library
2) add some entries and set Javadoc locations on them
3) also set access rule(s) to user library
4) exit eclipse and restart
5) erify that javdoc locations and access rules are still defined on created
user library...

Added test case in JavaProjectTests. However, this test only verify that extra
attributes and access rules are well written in workspace preferences. It was
not possible to verify that at startup, these preferences were well read...
Comment 6 Frederic Fusier CLA 2005-05-27 03:35:25 EDT
*** Bug 96854 has been marked as a duplicate of this bug. ***
Comment 7 Olivier Thomann CLA 2005-05-27 09:58:30 EDT
Verified in I20050526-2000
Comment 8 Frederic Fusier CLA 2005-06-03 04:16:40 EDT
*** Bug 98235 has been marked as a duplicate of this bug. ***