Bug 87845

Summary:	[1.5][dom][javadoc] allow javadoc references to vararg methods
Product:	[Eclipse Project] JDT	Reporter:	Jim des Rivieres <jeem>
Component:	Core	Assignee:	Frederic Fusier <frederic_fusier>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	frederic_fusier, markus.kell.r, martinae
Version:	3.0
Target Milestone:	3.1 M6
Hardware:	All
OS:	All
Whiteboard:

Description Jim des Rivieres

2005-03-11 18:35:36 EST

MethodRefParameter nodes should support variable arity references
like "#foo(String...)" and "#foo(String... args)".

This problem is a follow-on from bug 83393.

The 1.5 spec for the Javadoc tool does not mention the possibility
of a variable arity indicator in method references. However, the 1.5
Javadoc tool itself does indeed support it. Since it makes sense to have
a way to explicitly refer to variable arity methods, it seems more likely
that the Javadoc spec is wrong in this case.

Comment 1 Jim des Rivieres

2005-03-11 18:47:23 EST

Added API to MethodRefParameter:
 public static final SimplePropertyDescriptor VARARGS_PROPERTY;
 public boolean isVarargs();
 public void setVarargs(boolean variableArity);

I've released changes to specs, basic node implementation, and basic tests.
Parts that also require changing:
- AST parser and binding resolver
- AST rewriter
- downstream clones of NaiveASTFlatterner

Comment 2 Frederic Fusier

2005-03-13 14:08:32 EST

I'll do AST parser and binding resolver changes

Comment 3 Martin Aeschlimann

2005-03-14 07:08:04 EST

added support to rewriter > 20050314

Comment 4 Frederic Fusier

2005-03-14 13:22:18 EST

Done for AST parser (changes done in ASTConverter) and binding resolver (no
change was requested for this new API).

[jdt-core-internal]
Test case added in ASTConverterJavadocTest.

Comment 5 Markus Keller

2005-03-17 06:18:34 EST

Added support to jdt.ui's ASTFlattener.

Comment 6 Olivier Thomann

2005-03-30 16:39:07 EST

Verified in I20050330-0500