Bug 87644

Summary:	Control access rules severity
Product:	[Eclipse Project] JDT	Reporter:	Jerome Lanneluc <jerome_lanneluc>
Component:	Core	Assignee:	Jerome Lanneluc <jerome_lanneluc>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jeffmcaffer, philippe_mulet, wassim.melhem
Version:	3.1
Target Milestone:	3.1 M6
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Jerome Lanneluc

2005-03-10 09:39:43 EST

I20050308

To be consistent with the runtime behavior where you can have strict and loose
access control to classes in required plugin, PDE needs to control the severity
of access rules. Some access rules would always be flagged as errors, some would
be flagged as warnings.

Comment 1 Jerome Lanneluc

2005-03-21 17:49:03 EST

Added the following APIs to control access rules severity:
- IAccessRule
    int K_ACCESSIBLE;
    int K_NON_ACCESSIBLE;
    int K_DISCOURAGED;
    IPath getPattern();
    int getKind();
- JavaCore
    String COMPILER_PB_DISCOURAGED_REFERENCE;
    IAccessRule newAccessRule(IPath pattern, int kind);
    IClasspathEntry newContainerEntry(
			IPath containerPath, 
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newLibraryEntry(
			IPath path,
			IPath sourceAttachmentPath,
			IPath sourceAttachmentRootPath,
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newProjectEntry(
			IPath path, 
			IAccessRule[] accessRules, 
			boolean combineAccessRules,
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
    IClasspathEntry newVariableEntry(
			IPath variablePath,
			IPath variableSourceAttachmentPath,
			IPath variableSourceAttachmentRootPath,
			IAccessRule[] accessRules, 
			IClasspathAttribute[] extraAttributes,
			boolean isExported);
- IClasspathEntry
    boolean combineAccessRules();
    IAccessRule[] getAccessRules();

Comment 2 Wassim Melhem

2005-03-21 17:51:39 EST

Jerome, any chance the discouraged types are not in the code assist 
proposals?  or is that a separate issue?

Comment 3 Wassim Melhem

2005-03-21 17:52:21 EST

by discouraged, I also meant inaccessible ;-)

Comment 4 Jerome Lanneluc

2005-03-21 17:53:24 EST

That's a separate issue. David is adding flags to control this.

Comment 5 David Audel

2005-03-31 06:02:06 EST

Verified in I20050330-0500