Summary: | [Manifest Editor] Editor remains dirty after save | ||
---|---|---|---|
Product: | [Eclipse Project] PDE | Reporter: | DJ Houghton <dj.houghton> |
Component: | UI | Assignee: | Mike Pawlowski <mike.pawlowski> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | bjzhanghao, caniszczyk, dejan, eclipse, markus.kell.r, pascal, sja.eclipse, wassim.melhem |
Version: | 3.0.1 | Keywords: | polish |
Target Milestone: | 3.3 M7 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
DJ Houghton
2005-03-09 14:29:56 EST
File -> Save doesn't work either. the problem exists in 3.0, 3.0.x and still in 3.1. It is very specific to a scenario where we make the build editor dirty (check the checkbox) and then reverse it (uncheck it), ie. when we have a pending text operation in the build editor that is removed. Considering the rarity of this scenario and the fact that saving is possible when the red x is clicked, it is not critical for 3.0.2. We are dealing with a very sensitive area in the editor code here. *** Bug 90097 has been marked as a duplicate of this bug. *** *** Bug 93978 has been marked as a duplicate of this bug. *** *** Bug 107701 has been marked as a duplicate of this bug. *** Can this be considered for 3.3? *** Bug 165462 has been marked as a duplicate of this bug. *** *** Bug 175371 has been marked as a duplicate of this bug. *** *** Bug 180108 has been marked as a duplicate of this bug. *** *** Bug 173054 has been marked as a duplicate of this bug. *** Mike, can you please address this one as we kick off Manifest Editor Theme Week (April 10-13)? Fixed. Patch released to HEAD. Target: 3.3 M7 Patch: patch_87549_2007-04-10_14-13.txt The problem was that various user editor actions yielded text edit operations that cancelled each other out. This prevented the need to flush the underlying plug-in XML files input context and correctly clear the editor's dirty state; since, the model was already synchronized. Verified this fix using all the different scenarios listed in this bug report as duplicates. Also verified this fix for a great number of other scenarios that could easily put the editor in a perpetual dirty state due to this bug. Thanks Mike. A great way to kick off Manifest Editor Theme week. |