Bug 85922

Summary: gdk_draw_layout_with_colors spends too much time drawing the background
Product: [Eclipse Project] Platform Reporter: Billy Biggs <billy.biggs>
Component: SWTAssignee: Billy Biggs <billy.biggs>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Mike_Wilson
Version: 3.1Keywords: performance
Target Milestone: ---   
Hardware: PC   
OS: Linux-GTK   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Billy Biggs CLA 2005-02-19 20:28:51 EST
I20050218-1600

It seems that GTK+ spends too much time drawing the background colour in calls
to gdk_draw_layout_with_colors().  The fix is to simply do the background fill
yourself using gdk_draw_rectangle() before drawing the layout.  I filed this bug
upstream:

  http://bugzilla.gnome.org/show_bug.cgi?id=167917

The patch attached speeds up the performance tests for me, but it requires testing.
Comment 1 Billy Biggs CLA 2005-02-19 20:29:17 EST
Created attachment 18126 [details]
Patch
Comment 2 Mike Wilson CLA 2005-04-21 10:39:02 EDT
Are we incorporating this patch?
Comment 3 Billy Biggs CLA 2005-11-14 22:52:31 EST
As it turns out, this was mainly due to a GTK+ bug which is now fixed.  Given
that the buggy version is not shipped in any current distributions, and because
the fix is awkward, I am closing this as WONTFIX for now.