Bug 77358

Summary:	[implementation] Release lock on CU prior to model change notification
Product:	[Eclipse Project] JDT	Reporter:	Christof Marti <christof_marti>
Component:	Text	Assignee:	JDT-Text-Inbox <jdt-text-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, dirk_baeumer
Version:	3.1
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Christof Marti

2004-11-01 06:34:39 EST

Currently the JavaReconcilingStrategy (and others) holds a lock on the CU during
the entire reconcile() including the model change notification. Holding a lock
when notifying listeners is deadlock prone.

The suggested solution is to essentially put the synchronized block in
IWorkspaceRunnable and call JavaCore#run(IWorkspaceRunnable, ISchedulingRule,
IProgressMonitor) with a ISchedulingRule for the CU. Model change notification
happens only after the runnable was called.

Comment 1 Dani Megert

2004-11-01 14:01:13 EST

Need also revisit other callers of reconcile() in JDT Text and JDT UI land.

Comment 2 Dani Megert

2005-05-27 04:11:55 EDT

Deferred.

Comment 3 Eclipse Genie

2019-04-20 13:35:08 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Eclipse Genie

2021-04-13 14:57:43 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 5 Eclipse Genie

2023-04-07 00:25:12 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.