Summary: | Compare should show png, bmp, etc. as image | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> |
Component: | Compare | Assignee: | Andre Weinand <andre_weinand> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | ||
Version: | 3.0 | ||
Target Milestone: | 3.1 M7 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Markus Keller
2004-07-13 10:20:26 EDT
Here's a patch I found in my workspace that adds bmp, jpeg, and png. I think this would be a nice polish item and would be convenient when we have to refresh/compare screenshots for the 3.1 documentation. Index: plugin.xml =================================================================== RCS file: /home/eclipse/org.eclipse.compare/plugin.xml,v retrieving revision 1.56 diff -u -r1.56 plugin.xml --- plugin.xml 8 May 2005 15:10:46 -0000 1.56 +++ plugin.xml 9 May 2005 15:40:45 -0000 @@ -301,7 +301,7 @@ id="org.eclipse.compare.TextMergeViewerCreator"> </viewer> <viewer - extensions="gif,jpg" + extensions="bmp,gif,jpeg,jpg,png" class="org.eclipse.compare.internal.ImageMergeViewerCreator" id="org.eclipse.compare.ImageMergeViewerCreator"> </viewer> Thanks Markus. I've added (and verified) ico,tif, and tiff as well. I think when I made that modification, I ran into bug 57382 (some tiff formats are rendered as a black rectangle). But even with that bug, a black rectangle is probably more interesting than textual garbage :-). The TIFFs I've tried, all worked... |