Bug 69920 - Compare should show png, bmp, etc. as image
Summary: Compare should show png, bmp, etc. as image
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.1 M7   Edit
Assignee: Andre Weinand CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-07-13 10:20 EDT by Markus Keller CLA
Modified: 2005-05-09 14:51 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2004-07-13 10:20:26 EDT 
Eclipse 3.0.

Compare Viewers should be able to show more image formats than *.gif and *.jpg.
In particular, I miss *.png and *.jpeg. Currently, a text (garbage) compare is
shown.

From what I read in ImageLoader's javadoc, *.bmp and *.ico should also be
supported. It looks like *.tiff and *.tif should also work (at least in win32).
Comment 1 Markus Keller CLA 2005-05-09 11:47:23 EDT 
Here's a patch I found in my workspace that adds bmp, jpeg, and png.

I think this would be a nice polish item and would be convenient when we have to
refresh/compare screenshots for the 3.1 documentation.

Index: plugin.xml
===================================================================
RCS file: /home/eclipse/org.eclipse.compare/plugin.xml,v
retrieving revision 1.56
diff -u -r1.56 plugin.xml
--- plugin.xml	8 May 2005 15:10:46 -0000	1.56
+++ plugin.xml	9 May 2005 15:40:45 -0000
@@ -301,7 +301,7 @@
             id="org.eclipse.compare.TextMergeViewerCreator">
       </viewer>
       <viewer
-            extensions="gif,jpg"
+            extensions="bmp,gif,jpeg,jpg,png"
             class="org.eclipse.compare.internal.ImageMergeViewerCreator"
             id="org.eclipse.compare.ImageMergeViewerCreator">
       </viewer>
Comment 2 Andre Weinand CLA 2005-05-09 12:35:32 EDT 
Thanks Markus.
I've added (and verified) ico,tif, and tiff as well.
Comment 3 Markus Keller CLA 2005-05-09 13:18:36 EDT 
I think when I made that modification, I ran into bug 57382 (some tiff formats
are rendered as a black rectangle). But even with that bug, a black rectangle is
probably more interesting than textual garbage :-).
Comment 4 Andre Weinand CLA 2005-05-09 14:51:49 EDT 
The TIFFs I've tried, all worked...