Bug 576700

Summary: Update view menu color
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, ma.becker, wim.jongman
Version: 4.22   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=551604
Whiteboard:
Bug Depends on: 495033    
Bug Blocks:    
Attachments:
Description Flags
Windows light
none
Windows dark none

Description Lars Vogel CLA 2021-10-18 09:37:40 EDT
We should update the the view menu icon color to match the foreground color of the close icon (and with Bug 487303 of the min/ max.
Comment 1 Wim Jongman CLA 2021-10-18 10:46:09 EDT
Can you make this visual?
Comment 2 Lars Vogel CLA 2021-10-18 10:55:18 EDT
(In reply to Wim Jongman from comment #1)
> Can you make this visual?

I'm not sure what you mean. I think removing the white fill color might already improve the icon.
Comment 3 Matthias Becker CLA 2021-10-18 10:57:00 EDT
(In reply to Lars Vogel from comment #2)
> (In reply to Wim Jongman from comment #1)
> > Can you make this visual?
> 
> I'm not sure what you mean. I think removing the white fill color might
> already improve the icon.

replace the white fill with transparency?
Comment 4 Lars Vogel CLA 2021-10-18 11:04:12 EDT
(In reply to Matthias Becker from comment #3)
> (In reply to Lars Vogel from comment #2)
> > (In reply to Wim Jongman from comment #1)
> > > Can you make this visual?
> > 
> > I'm not sure what you mean. I think removing the white fill color might
> > already improve the icon.
> 
> replace the white fill with transparency?

Yes. :-)
Comment 5 Wim Jongman CLA 2021-10-18 11:07:27 EDT
Created attachment 287332 [details]
Windows light
Comment 6 Wim Jongman CLA 2021-10-18 11:08:13 EDT
Created attachment 287333 [details]
Windows dark
Comment 7 Lars Vogel CLA 2021-10-18 11:14:28 EDT
Unfortunately, if we remove the fill colors the color is too light for the light theme and to dark for the dark theme. 

I think we face again the issue that we would have to use different icons for the different themes.
Comment 8 Andrey Loskutov CLA 2021-10-18 11:15:04 EDT
(In reply to Wim Jongman from comment #6)
> Created attachment 287333 [details]
> Windows dark

I don't see any differences, in both Light/Dark versions.
Comment 9 Wim Jongman CLA 2021-10-18 11:25:26 EDT
(In reply to Andrey Loskutov from comment #8)
> (In reply to Wim Jongman from comment #6)
> > Created attachment 287333 [details]
> > Windows dark
> 
> I don't see any differences, in both Light/Dark versions.

Me neither. I want to understand the issue but I don't see it on windows. Is it a Linux problem?