Summary: | Less lines/border in the compare editor widgets | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Mickael Istria <mistria> | ||||||
Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> | ||||||
Status: | NEW --- | QA Contact: | |||||||
Severity: | enhancement | ||||||||
Priority: | P3 | ||||||||
Version: | 4.21 | ||||||||
Target Milestone: | --- | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
See Also: | https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/183971 | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Mickael Istria
2021-08-12 05:35:41 EDT
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.team/+/183971 Created attachment 286927 [details]
Before patch (current master)
Created attachment 286928 [details]
After patch
Those screenshot do show current proposal gets rid of a few heavy lines and save 2 pixels in width/height.
Some extra lines could still be removed (in further patches).
One issue I see here is that the TextViewers themselves are delegated to extensions (eg Java or other editors), but those extensions usually don't set the SWT.BORDER styles for the widgets and there is no good way to forward the style from editor to viewers. So it's a bit tricky to remove some of the lines while emulating a border. |