Bug 574815

Summary:

[macOS] Dock context menu does not show shells any more

Product:

[Eclipse Project] Platform

Reporter:

Thomas Singer <ts-swt>

Component:

SWT

Assignee:

Platform-SWT-Inbox <platform-swt-inbox>

Status:

NEW ---

QA Contact:

Severity:

normal

Priority:

CC:

alexandr.miloslavskiy, nikita, niraj.modi, sravankumarl, ts-swt

Version:

4.21

Target Milestone:

---

Hardware:

OS:

Mac OS X

See Also:

https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183053

Whiteboard:

Attachments:

Description	Flags
Snippet to reproduce	none
Screenshot for SWT v4932r13 - good	none
Screenshot for SWT v4932r14 - bad	none

Description Thomas Singer

2021-07-13 06:10:10 EDT

Please launch the attached snippet on macOS (tried 10.14.6) with SWT v4932r13. 2 shells should occur. Right-click the Dock icon and you will see them listed. Now use SWT v4932r14 and the entries for the shells in the Dock icon popup are gone.

Comment 1 Thomas Singer

2021-07-13 06:10:46 EDT

Created attachment 286773 [details]
Snippet to reproduce

Comment 2 Thomas Singer

2021-07-13 06:12:09 EDT

Created attachment 286774 [details]
Screenshot for SWT v4932r13 - good

Comment 3 Thomas Singer

2021-07-13 06:12:35 EDT

Created attachment 286775 [details]
Screenshot for SWT v4932r14 - bad

Comment 4 Niraj Modi

2021-07-14 06:18:43 EDT

Hi Nikita,
Do you see if any of below patches would have caused this issue seen with attachment 286773 [details] on MAC ?

Between v4932r13 and v4932r14 below two commits have MAC related changes:
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=30ad38d69b91bac02f587cec89b564c73a903bdb

https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=552c841cdec57d1445d04f981fead6cc3fbd21c8

Comment 5 Nikita Nemkin

2021-07-14 06:33:55 EDT

Hi Niraj.

The first change only affects SWT_AWT, which the repro snipped doesn't use.
The second change is completely neutral, shouldn't have any observable effect.

Maybe removing "-framework JavaVM" from LDFLAGS in the SWT_AWT patch triggered some internal compatibility change?

Comment 6 Eclipse Genie

2021-07-14 07:11:40 EDT

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/183053

Comment 7 Niraj Modi

2021-07-14 08:48:05 EDT

(In reply to Nikita Nemkin from comment #5)
> Hi Niraj.
> 
> The first change only affects SWT_AWT, which the repro snipped doesn't use.
> The second change is completely neutral, shouldn't have any observable
> effect.
> 
> Maybe removing "-framework JavaVM" from LDFLAGS in the SWT_AWT patch
> triggered some internal compatibility change?

Checked with Sravan on "-framework JavaVM" usage: It has been removed from Xcode 12.2(needed for aarch64 support).
And putting this flag back causes the native MAC build to fail.

So to narrow it down further, we will need to revert the mentioned patches in comment 4 and confirm if any of this has cause this issue. Thanks!

Any other ideas are welcome here.