Summary: | [e4][tooling] Add header check for new fragment header | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Christoph Laeubrich <laeubi> |
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | alexander.fedorov, julian.honnen, mistria |
Version: | 4.20 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=571866 https://bugs.eclipse.org/bugs/show_bug.cgi?id=572946 |
||
Whiteboard: | |||
Bug Depends on: | 572919 | ||
Bug Blocks: |
Description
Christoph Laeubrich
2021-04-19 03:57:06 EDT
Implementing the new PDE extension point in e4 tools would introduce a dependency from Platform to PDE. Is that OK? (In reply to Julian Honnen from comment #1) > Implementing the new PDE extension point in e4 tools would introduce a > dependency from Platform to PDE. Is that OK? Generally it is not OK, but I'm not sure that e4 tools is the part of the Platform. Please specify the exact pair of bundles that will have a dependency. (In reply to Julian Honnen from comment #1) > Implementing the new PDE extension point in e4 tools would introduce a > dependency from Platform to PDE. Is that OK? No objection from me, but please ask others via the mailing-list. I personally always thought that e4 tools in general should have been part of PDE more than Platform. (In reply to Julian Honnen from comment #1) > Implementing the new PDE extension point in e4 tools would introduce a > dependency from Platform to PDE. Is that OK? e4.core.tools currently depends on > org.eclipse.pde.core;bundle-version="3.9.0", > org.eclipse.pde.ui;bundle-version="3.8.0" and even uses internal API, so I really don't see any reason to be much concerned here. (In reply to Christoph Laeubrich from comment #4) > (In reply to Julian Honnen from comment #1) > > Implementing the new PDE extension point in e4 tools would introduce a > > dependency from Platform to PDE. Is that OK? > > e4.core.tools currently depends on > > > org.eclipse.pde.core;bundle-version="3.9.0", > > org.eclipse.pde.ui;bundle-version="3.8.0" > > and even uses internal API, so I really don't see any reason to be much > concerned here. So, nothing new from dependency POV, right? |