Bug 571934

Summary:	AsyncCompletionProposalPopup.displayProposals() called twice
Product:	[Eclipse Project] Platform	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	Text	Assignee:	Platform-Text-Inbox <platform-text-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.20
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=553577 https://bugs.eclipse.org/bugs/show_bug.cgi?id=569668
Whiteboard:

Description Stephan Herrmann

2021-03-13 07:40:30 EST

While debugging bug 569668 I noticed that AsyncCompletionProposalPopup.displayProposals() is called twice for the same popup, which looks wasteful at least - I measured several hundreds of milliseconds in the debugger (I did not observe an outright bug - yet).

This is caused by https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=90e69fcf2b64d43dade977d6b1de50ae70c9d2f4 from bug 553577. More specifically, since that commit computeAndPopulateProposals() unconditionally at its end calls displayProposals() -- no matter that the same call may have happened before already.