Bug 570641

Summary:	Remove menu-update from Workbench when keybindings change
Product:	[Eclipse Project] Platform	Reporter:	Rolf Theunissen <rolf.theunissen>
Component:	UI	Assignee:	Rolf Theunissen <rolf.theunissen>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel
Version:	4.18
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
See Also:	https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/175341
Whiteboard:

Description Rolf Theunissen

2021-01-25 14:28:01 EST

Workbench registers a bindingManagerListener to trigger an update on the main menu when the active binding change. However, this update is already triggered in multiple places.

Comment 1 Eclipse Genie

2021-01-25 14:32:27 EST

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/175341

Comment 2 Rolf Theunissen

2021-01-28 05:13:48 EST

From the Gerrit review this change causes a regression, i.e. there is a interaction between menu-mnemonic and short-cuts. In fact, it practically reverses the fix for Bug 65775.
As suggested in that Bug, it might be more efficient to move the listener to keybindings inside the MenuManager.

My main concern with the current implementation was that the menumanager in the Workbench must be initialized very early (no lazy initialization), while I like to initialize it after the menu-renders are initialized.

Also note that there are still issues with the the disabling of menu-mnemonics, the remainder of Bug 208626 for toplevel menus.