Bug 568311

Summary:	Parallel build doesn't consider rebuildRequested flag
Product:	[Eclipse Project] Platform	Reporter:	Andrey Loskutov <loskutov>
Component:	Resources	Assignee:	Platform-Resources-Inbox <platform-resources-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	gautier.desaintmartinlacaze
Version:	4.8
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=530649
Whiteboard:
Bug Depends on:
Bug Blocks:	527212

Description Andrey Loskutov

2020-10-27 13:05:27 EDT

While working on bug 568299 I've noticed, that BuildManager.rebuildRequested flag is not used by parallelBuildLoop() introduced via bug 530649.

That means, if the builder requests a rebuild during a parallel build, nothing will happen, and most likely the result would be not the one that would be during sequential build.

Historically rebuildRequested flag was added to resolve build cycles in JDT (so the sequential build also considers IWorkspaceDescription.getMaxBuildIterations()), but we are also use it in our application to re-trigger the build cycle if we detect and fix some project configuration issues (wrong JDT settings etc).

So for me looks like BuildManager.parallelBuildLoop() should consider both rebuildRequested & getMaxBuildIterations() to produce same results as the sequential build.

I have not searched explicitly for related bugs, but bugzilla offered me bug 510389 as a possible candidate that could be related.