Summary: | Update the macOS archive names | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Liviu Ionescu <ilg> |
Component: | Releng | Assignee: | Platform-Releng-Inbox <platform-releng-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | jonah, mknauer |
Version: | 4.21 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Mac OS X | ||
Whiteboard: |
Description
Liviu Ionescu
2020-10-25 14:36:23 EDT
I took a look at the EPP sources and tried to identify where the name of the archive comes from. It is defined as: <product> <id>${project.artifactId}</id> <rootFolder>eclipse</rootFolder> <rootFolders> <macosx>Eclipse.app</macosx> </rootFolders> <archiveFileName>${build}_eclipse-${eclipse.epp.id}-${eclipse.simultaneous.release.id}</archiveFileName> </product> So the 'macos-cocoa-x86_64' part comes as '${eclipse.simultaneous.release.id}'. Unfortunately my knowledge of SimRel is not enough to suggest a solution. :-( If this requires another issue in SimRel, please fell free to add it. It would be possible to rename the .dmg/.tar.gz at the last step (sort of how we change . to - in the names). However that would make EPP inconsistent with SDK and that makes me a little uncomfortable.
> So the 'macos-cocoa-x86_64' part comes as
> '${eclipse.simultaneous.release.id}'.
The .macosx. in the name does not come from eclipse.simultaneous.release.id. that id is "2012-12-M2". The archiveFileName is appended with the target triplet by tycho. The target triplet comes from the <environments> section in the pom.xml. However you can only define an environment triplet that has a matching org.eclipse.equinox.launcher plug-in. So you can't change the macosx one to macos because there is no org.eclipse.equinox.launcher.cocoa.macos.x86_64 bundle, the bundle is org.eclipse.equinox.launcher.cocoa.macosx.x86_64.
So I don't know how or when this name should change, but I don't think I am going to lead it.
If Platform change the names of the packages (and I suppose the keys for OS?) then EPP will follow suit. So this bug belongs with Platform for their consideration. |