Bug 567848

Summary: Keybindings are kicked out by the model assembler
Product: [Eclipse Project] Platform Reporter: Wim Jongman <wim.jongman>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3    
Version: 4.18   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Bug Depends on:    
Bug Blocks: 552208    
Attachments:
Description Flags
Application model vs Runtime model none

Description Wim Jongman CLA 2020-10-13 14:58:24 EDT 
Created attachment 284441 [details]
Application model vs Runtime model

I can't get my keybindings to work in a simple e4 application. 

Adding the model spy, showed that my keybindings were not in the model.

I debugged the ModelAssembler process and found code that it explicitly removed all keybindings in the model that were not tagged "type:user" [1]

This was introduced by bug 406003 [1].

The keybindings should not be silently dropped.


[2] https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=953285631d9aa17b85009ec67ebeda1e06f5ea33
Comment 1 Wim Jongman CLA 2020-10-14 09:22:05 EDT 
(In reply to Wim Jongman from comment #0)

> 
> 
> [2]
> https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/
> ?id=953285631d9aa17b85009ec67ebeda1e06f5ea33

Darn, I linked the wrong patch. Sorry for the spam. It's here [1].

The idea of bug 406003 seems logical, but it is broken in some cases. I will try to figure out what is wrong with it. With PW gone, I assume we no longer have experts in this area. 


https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=cc298fea671240a16fe977aa8ee2b70274de70d5