Description
Andrew Johnson
2020-10-09 09:12:22 EDT
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170548 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170548 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=00ed4972e4fa23b96c29031a95b947cd273b5bbc Another useful idea is to be able to move the tabs. A solution I came up with is to move the current tab left or right, with a keyboard accelerator to make it easy, and leave the menu active afterwards to allow the tab to be moved again. I didn't see a way of bringing up the tab pop-up menu, so I added a shift-F10 key listener. This should be a command/action to allow key binding to be set but I didn't do that. New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170582 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170582 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=a66a3f968efc3816a55709f313a6ebdd04bd7798 Created attachment 284417 [details]
Screenshot showing move tabs
New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170605 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170605 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=c45769311e77dbc2d145c0202746aaff874fd043 New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170606 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170606 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=eaa1de7287a1084f4178a6ef55ff453930050da1 New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170637 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/170637 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=fe916c34e7a994769b59bfb217e5e6eca181ab95 The menu is now brought up using a command, active on the editor view, so is using ctrl-F10 to avoid confusion with the context menu on shift-F10. Test using keyboard to bring up menu with ctrl-F10 once tab is selected, then L/R to move tabs, or up/down to select other options. Test using mouse to bring up menu on active or non-active tabs, and move using keyboard / mouse. Check that active tab remains active and toolbar is correct. The key assignments Ctrl-F8 Ctrl-Shift-F8 are different from Eclipse IDE where than means next/previous perspective. Ctrl-PageDown and Ctrl-PageUp are already the defaults for tab movement. Also Ctrl-F10 is show view menu e.g. for the Error log view. Perhaps Alt-F10 would be better (shift and ctrl are already used) New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171342 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171342 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=71e75d20b3b8f18989a4c6db26a8084deb28c421 New Gerrit change created: https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171359 Gerrit change https://git.eclipse.org/r/c/mat/org.eclipse.mat/+/171359 was merged to [master]. Commit: http://git.eclipse.org/c/mat/org.eclipse.mat.git/commit/?id=278092b1778f10f425c6f402ad0760baedb7bc3c On Ubuntu, ctrl-F10 brings up the menu, L or R moves the tab, but the menu is not recreated so pressing L again doesn't move the tab further, unless ctrl-F10 is pressed again first. Other than that, this task is done. |