Bug 565584

Summary: Make flat tabs default on macOS to match themes on other platforms
Product: [Eclipse Project] Platform Reporter: Alex Blewitt <alex.blewitt>
Component: UIAssignee: Alex Blewitt <alex.blewitt>
Status: ASSIGNED --- QA Contact:
Severity: enhancement    
Priority: P3 CC: aobuchow, gayan_per
Version: 4.17   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166907
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565556
Whiteboard:
Attachments:
Description Flags
Screenshot showing flat tabs
none
Screenshot with fix for patch 1 of gerrit change
none
Sreenshot showing D6D6D6 colouring
none
Screenshot showing F6F6F6 none

Description Alex Blewitt CLA 2020-07-27 12:52:56 EDT 
According to https://twitter.com/gaparv/status/1287476922897895424 the default for Windows and Linux is now to use flat tabs, while macOS uses rounded tabs still. Implement the necessary fixes to ensure consistency between operating systems.
Comment 1 Alex Blewitt CLA 2020-07-27 12:53:58 EDT 
Created attachment 283715 [details]
Screenshot showing flat tabs
Comment 2 Andrew Obuchowicz CLA 2020-07-27 12:59:43 EDT 
@Alex I saw the discussion on twitter.
From what I gather, the issue is that the inactive tabs are using a color gradient.

Although I can't do testing myself as I don't own a Mac, I can help with the CSS fix/review.
Comment 3 Alex Blewitt CLA 2020-07-27 13:01:01 EDT 
I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package.
Comment 4 Andrew Obuchowicz CLA 2020-07-27 13:02:58 EDT 
(In reply to Alex Blewitt from comment #3)
> I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer
> package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package.

See my previous comment, I believe Gayan's issue is the colors are not flat (a gradient is used) despite the fact that square corners are now being used on OSX.
Comment 5 Alex Blewitt CLA 2020-07-27 13:11:02 EDT 
(In reply to Andrew Obuchowicz from comment #4)
> (In reply to Alex Blewitt from comment #3)
> > I see the rounded tabs on 2020-03 with the Eclipse IDE for Eclipse Committer
> > package, but not with the 2020-06 Eclipse IDE for Eclipse Committers package.
> 
> See my previous comment, I believe Gayan's issue is the colors are not flat
> (a gradient is used) despite the fact that square corners are now being used
> on OSX.

Ah, I see. Will verify that is indeed the case. If you know where/how I can apply the CSS fixes, I'm more than happy to build/test it. Or if you want to propose a Gerrit, I can pull that and do the verification - whichever is easier :)
Comment 6 Eclipse Genie CLA 2020-07-27 13:29:08 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166907
Comment 7 Andrew Obuchowicz CLA 2020-07-27 13:31:31 EDT 
> Ah, I see. Will verify that is indeed the case. If you know where/how I can
> apply the CSS fixes, I'm more than happy to build/test it. Or if you want to
> propose a Gerrit, I can pull that and do the verification - whichever is
> easier :)

Awesome thank you! I tried making a Gerrit, hopefully it fixes the issue :P Will add you as a reviewer :)
Comment 8 Alex Blewitt CLA 2020-07-27 13:50:09 EDT 
Created attachment 283716 [details]
Screenshot with fix for patch 1 of gerrit change
Comment 9 Alex Blewitt CLA 2020-07-27 13:52:26 EDT 
So in the fix for patchset 1 at https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/166907 it looks pretty good, but I will see if I can tweak it to be a little bit more native.
Comment 10 Alex Blewitt CLA 2020-07-28 04:36:47 EDT 
Created attachment 283720 [details]
Sreenshot showing D6D6D6 colouring
Comment 11 Alex Blewitt CLA 2020-07-28 04:37:07 EDT 
Created attachment 283721 [details]
Screenshot showing F6F6F6