Bug 56490

Summary: [Problems] Remove delete action from the Problem View
Product: [Eclipse Project] Platform Reporter: Brock Janiczak <brockj>
Component: UIAssignee: Tod Creasey <Tod_Creasey>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: n.a.edgar
Version: 3.0Keywords: polish
Target Milestone: 3.2 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch to only show delete action for editable marker types
none
Patch to remove tool item none

Description Brock Janiczak CLA 2004-03-28 02:02:24 EST 
3.0 M8

The delete action on the problem view can never be activated and therefore does
nothing.  The action will only enable for subtypes of Task and Bookmark where
they are user editable.  It doesn't really make sense to have a delete action
for problems anyway as they can only be 'resolved', not deleted.

I proppose to add a method isMarkerTypeEditable to the Util class and use this
to determine whether to add the delete action to the toolbar and context menu. 
The root marker type would have to be used as there doesn't seem to be any easy
way to access the MarkerManager.

I could provide a patch if this is deemed a problem.
Comment 1 Brock Janiczak CLA 2004-04-16 01:34:44 EDT 
Created attachment 9564 [details]
Patch to only show delete action for editable marker types

changes to:
org.eclipse.ui.views.markers.internal.Util
org.eclipse.ui.views.markers.internal.MarkerView

Added isRootMarkerTypeEditable to Util
Updated MarkerView to use this new method to determine if the delete button
could ever be enabled.

NOTE: the formatting of the new code does not match the existing code
Comment 2 Tod Creasey CLA 2005-11-03 10:57:28 EST 
*** Bug 58549 has been marked as a duplicate of this bug. ***
Comment 3 Tobias Schwarz CLA 2006-01-24 04:57:01 EST 
when will this patch be integrated in standard eclipse?
shouldn't this be done with 3.2?
Comment 4 Tod Creasey CLA 2006-01-24 08:19:26 EST 
I'll try to look at it for M5.
Comment 5 Tod Creasey CLA 2006-01-24 14:53:11 EST 
I went for a simpler (and more effecient approach). I now ask the view if it is possible to edit a marker ever.
Comment 6 Tod Creasey CLA 2006-01-24 14:53:35 EST 
Fixed in build >20060124
Comment 7 Tod Creasey CLA 2006-02-13 14:44:56 EST 
We still have it in the toolbar in 20060213-1200
Comment 8 Tod Creasey CLA 2006-02-17 14:35:32 EST 
Created attachment 34941 [details]
Patch to remove tool item
Comment 9 Tod Creasey CLA 2006-02-20 09:35:16 EST 
Fixed in build >20060220
Comment 10 Tod Creasey CLA 2006-03-29 07:57:07 EST 
Verified in 20060328