Summary: | Tabs in the tab stack have no separators | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Andrey Loskutov <loskutov> | ||||
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||
Status: | NEW --- | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | aobuchow, Lars.Vogel, mmarchand, pyvesdev | ||||
Version: | 4.16 | Keywords: | regression | ||||
Target Milestone: | --- | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=538740 | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Andrey Loskutov
2020-05-26 08:38:11 EDT
Thanks Andrey, looks like nobody noticed this in the M3 validation week. Mike, Andrew or Pierre-Yves, can you have a look? I personally don't mind the lack of seperator's, but VSCode & Firefox do use tab seperators so we probably should do the same. I can most-likely contribute a patch, although Pierre-Yves or Mike might be able to do it faster (as improving the Maven language server is a top priority for me until 4.16 is released). Hey Lars, I think the reason it was never noticed is because we've never had separators for tabs in the CTabRendering. I can try to have a look once I solve a regression that was introduced with the introduction of square tabs. Mike, can you take this? I also think separators are nicer. Mike, when you create a patch please add me as a reviewer :) And if you get caught up, I can try making a patch as well (once 4.16 is released) just let me know. (In reply to Andrew Obuchowicz from comment #5) > Mike, when you create a patch please add me as a reviewer :) > > And if you get caught up, I can try making a patch as well (once 4.16 is > released) just let me know. +1 Mike, are you still planning to work on this? I can try to take a crack at this over the next week or two. (In reply to Mike Marchand from comment #8) > I can try to take a crack at this over the next week or two. Any update? I will use some time this week to see what it'll take. (In reply to Mike Marchand from comment #10) > I will use some time this week to see what it'll take. Any chance to have the patch for 4.17? That was my goal. Unfortunately, with a loss in the family recently, I have not put the time into this that I had initially planned. I wanted to solve this in a way that the separators were optional, that way we could maintain the current look by tuning some CSS. |