Bugzilla – Full Text Bug Listing
| Summary: | Duplicated classes for QuickDiff commands | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Wolf <twolf> |
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
| Status: | NEW --- | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 4.16 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
There are several duplicated classes relating to QuickDiff between bundles org.eclipse.ui.editors and org.eclipse.ui.workbench.texteditor. * org.eclipse.ui.internal.editors.quickdiff * org.eclipse.ui.internal.texteditor.quickdiff Interesting is that these classes were originally in o.e.ui.editors. They then got moved to o.e.ui.workbench.texteditor in commits e551b7b8 and 42995157, and later re-introduced in o.e.ui.editors in commit 12d9623b ("get rid of internal imports"). The commits are from 2003/2004, and don't reference any bugzilla issue. o.e.ui.editors does have a dependency on o.e.ui.workbench.texteditor. Why is that code duplicated? We do have x-friends nowadays, so we could make the classes from the texteditor bundle visible selectively to the editor bundle. Was the code copied because at that time x-friends didn't exist? What's going on there?