Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
It should be sufficient to do this:
display.setData("org.eclipse.swt.internal.win32.enableDarkScrollbars", true)
(In reply to Alexandr Miloslavskiy from comment #1) > It should be sufficient to do this: > > display.setData("org.eclipse.swt.internal.win32.enableDarkScrollbars", true) Thanks. We currently have two plug-ins used for the purpose to set the dark theme: org.eclipse.e4.ui.swt.gtk org.eclipse.e4.ui.workbench.renderers.swt.cocoa I think I put the call windows call together with the gtk call into org.eclipse.e4.ui.swt.gtk @Alexander, should I rename the plug-in or would that break something? (In reply to Lars Vogel from comment #3) > We currently have two plug-ins used for the purpose to set the dark theme: > > org.eclipse.e4.ui.swt.gtk > org.eclipse.e4.ui.workbench.renderers.swt.cocoa > > I think I put the call windows call together with the gtk call into > org.eclipse.e4.ui.swt.gtk > > @Alexander, should I rename the plug-in or would that break something? Not sure if I can put these calls together without unified API, I think this will create compile errors on the corresponding platform. I have no idea, sorry. I don't really use Eclipse, and my SWT patches are aimed for other product that uses SWT. It doesn't use Eclipse plugins. (In reply to Lars Vogel from comment #3) > We currently have two plug-ins used for the purpose to set the dark theme: > > org.eclipse.e4.ui.swt.gtk > org.eclipse.e4.ui.workbench.renderers.swt.cocoa > > I think I put the call windows call together with the gtk call into > org.eclipse.e4.ui.swt.gtk > > @Alexander, should I rename the plug-in or would that break something? You should not put win32 calls in gtk fragment. You have to create new fragment for win32 and put it there. This is needed as the gtk fragment uses gtk specific swt calls thus we need one fragment per WS. New Gerrit change created: https://git.eclipse.org/r/160204 (In reply to Alexander Kurtakov from comment #6) > (In reply to Lars Vogel from comment #3) > > We currently have two plug-ins used for the purpose to set the dark theme: > > > > org.eclipse.e4.ui.swt.gtk > > org.eclipse.e4.ui.workbench.renderers.swt.cocoa > > > > I think I put the call windows call together with the gtk call into > > org.eclipse.e4.ui.swt.gtk > > > > @Alexander, should I rename the plug-in or would that break something? > > You should not put win32 calls in gtk fragment. You have to create new > fragment for win32 and put it there. This is needed as the gtk fragment uses > gtk specific swt calls thus we need one fragment per WS. I think if we solve Bug 546859 (unified API for setting the dark theme) we can get rid of the gtk (and the new win32 fragment). Created attachment 282439 [details]
Old / New side by side
Looks great, see attachment. Thanks Alexandr and Conrad for the SWT API.
New Gerrit change created: https://git.eclipse.org/r/160926 Gerrit change https://git.eclipse.org/r/160204 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b987db6af682f49cfae9d828efa26ac97bf11e3c New Gerrit change created: https://git.eclipse.org/r/160929 Gerrit change https://git.eclipse.org/r/160929 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4b398853ccf816ff603f3b287c68cbb277b54122 Gerrit change https://git.eclipse.org/r/160926 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=4be4500d67db4bdaa40e3c7268d9a2006cfcb6a9 New Gerrit change created: https://git.eclipse.org/r/163287 Gerrit change https://git.eclipse.org/r/163287 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=28af85e9e725ea439bafb375de9a0f9f09db4bfe (In reply to Eclipse Genie from comment #16) > Gerrit change https://git.eclipse.org/r/163287 was merged to [master]. > Commit: > http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/ > ?id=28af85e9e725ea439bafb375de9a0f9f09db4bfe The image in N&N is more than 800 pixel wide. Instruction is ". The image should be no more than 800 pixels wide and in PNG format " Can you please reattach a picture that fits the instruction. New Gerrit change created: https://git.eclipse.org/r/163315 Gerrit change https://git.eclipse.org/r/163315 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3b51202bd62184585a4938330d9af9cd6aa251f1 |