Summary: | Enhance configuration options for inline problem markers to work better with unfinished code | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Erik Brangs <erik.brangs> |
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | eclipse, mistria |
Version: | 4.14 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=553849 | ||
Whiteboard: |
Description
Erik Brangs
2020-01-18 14:25:26 EST
In bug 553849 comment 10, Niko explains that it's technically doable as the property is a bit-misk. So replacing the combo box by some checkboxes (one for each severity) could do the trick. We had some discussions about the settings UI at https://git.eclipse.org/r/#/c/142835/11/org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/internal/texteditor/codemining/annotation/AnnotationCodeMiningPreferenceConstants.java@42. The original implementation were checkboxes; after the discussion we settled on the current dropdown. We can change it, but first should have an agreement. (In reply to Niko Stotz from comment #2) > We had some discussions about the settings UI at > https://git.eclipse.org/r/#/c/142835/11/org.eclipse.ui.workbench.texteditor/ > src/org/eclipse/ui/internal/texteditor/codemining/annotation/ > AnnotationCodeMiningPreferenceConstants.java@42. The original implementation > were checkboxes; after the discussion we settled on the current dropdown. > > We can change it, but first should have an agreement. The discussion took place before this issue arose, so it's mostly outdated. Note that this issue is not really about the configuration, but really more about error code minings appearing too soon. Maybe instead of more configration, what users really want is that error code minings get shown only when document is not dirty. As described in bug 553849 comment 10, I edited the property for showing inline markers to not show markers on errors. However, the property kept getting overwritten by the preference recorder. It worked fine after I edited the property via the preference recorder GUI. I've tried it out for a while and not showing problem markers on errors is much better. Still, I think there is further room for improvement. There are still some less annoying markers that appear during code editing (e.g. warnings about unused variables). Is it likely that some improvements for this will land in one of the next releases? Even having a better GUI for configuring inline markers (e.g. the mentioned checkboxes) would be a good start. |